[Infra] ✅ updated Github actions (#114)

* updated github actions * removed composer github auth * PHPCS * removed package-lock.json from ignore to allow `npm ci` * added missing husky * ignore legacy * removed unused non existing import
elementor · Nov 13, 2024 · 88d5396 · 88d5396
1 parent afdac76
commit 88d5396
Show file tree

Hide file tree

Showing 11 changed files with 23,059 additions and 32 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -8,3 +8,4 @@ libraries/**
 coverage/**
 assets/build/**
 tests/**
+modules/legacy/assets/**
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -26,18 +26,14 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up PHP
-        uses: shivammathur/setup-php@a36e1e52ff4a1c9e9c9be31551ee4712a6cb6bd0 # 2.27.1
+        uses: shivammathur/setup-php@v2
         with:
           php-version: '7.4'
         env:
           fail-fast: 'true'
 
-      - name: OAuth Composer Authentication
-        run:
-          composer config -g github-oauth.github.com ${{ secrets.DEVOPS_TOKEN }}
-
       - name: Install Composer dependencies cache
-        uses: ramsey/composer-install@v2
+        uses: ramsey/composer-install@v3
 
       - name: Install Composer dependencies
         run:

diff --git a/.github/workflows/js-ci.yml b/.github/workflows/js-ci.yml
@@ -23,10 +23,10 @@ jobs:
         node-version: [18.x]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@@v4
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: 'npm'

diff --git a/.github/workflows/php-coding-standards.yml b/.github/workflows/php-coding-standards.yml
@@ -24,7 +24,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up PHP
-        uses: shivammathur/setup-php@a36e1e52ff4a1c9e9c9be31551ee4712a6cb6bd0 # 2.27.1
+        uses: shivammathur/setup-php@v2
         with:
           php-version: '7.4'
           coverage: none
@@ -39,11 +39,8 @@ jobs:
           phpcs -i
           composer --version
 
-      - name: Oauth Composer authentication
-        run: composer config -g github-oauth.github.com ${{ secrets.DEVOPS_TOKEN }}
-
       - name: Install dependencies
-        uses: ramsey/composer-install@83af392bf5f031813d25e6fe4cd626cdba9a2df6 # 2.2.0
+        uses: ramsey/composer-install@v3
 
       - name: Add error matcher
         run: echo "::add-matcher::$(pwd)/.github/checkstyle-problem-matcher.json"

diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml
@@ -51,7 +51,7 @@ jobs:
           MYSQL_DATABASE: wordpress_test
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Matrix variables
         id: matrix
@@ -76,7 +76,7 @@ jobs:
           fi
 
       - name: Set up PHP
-        uses: shivammathur/setup-php@a36e1e52ff4a1c9e9c9be31551ee4712a6cb6bd0 # 2.27.1
+        uses: shivammathur/setup-php@v2
         with:
           coverage: ${{ steps.coverage.outputs.coverage }}
           ini-values: ${{ steps.coverage.outputs.ini }}
@@ -89,12 +89,8 @@ jobs:
           wget -q -O /usr/local/bin/phpunit "https://phar.phpunit.de/phpunit-${{ matrix.phpunit }}.phar"
           chmod +x /usr/local/bin/phpunit
 
-      - name: Oauth Composer authentication
-        run:
-          composer config -g github-oauth.github.com ${{ secrets.DEVOPS_TOKEN }}
-
       - name: Install dependencies
-        uses: ramsey/composer-install@83af392bf5f031813d25e6fe4cd626cdba9a2df6 # 2.2.0
+        uses: ramsey/composer-install@v3
 
       #- name: Install Node.js
        # uses: actions/setup-node@v2
@@ -108,7 +104,7 @@ jobs:
       #  run: npm run build
 
       - name: Set up WordPress and WordPress Test Library
-        uses: sjinks/setup-wordpress-test-library@dd7f8144e892b042e034d713b734f7a19446abe1 # 2.0.1
+        uses: sjinks/setup-wordpress-test-library@master
         with:
           version: ${{ matrix.wp }}
 
@@ -137,10 +133,3 @@ jobs:
             OPTIONS="$OPTIONS --coverage-clover=clover.xml"
           fi
           phpunit --order-by=random ${OPTIONS}
-
-      - name: Upload coverage report
-        uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
-        with:
-          files: clover.xml
-          flags: unittests
-        if: ${{ steps.coverage.outputs.coverage != 'none' }}
diff --git a/.gitignore b/.gitignore
@@ -7,7 +7,6 @@ vendor/
 composer.lock
 npm-debug.log
 .DS_Store
-package-lock.json
 bin/.env
 */node_modules
 !assets/dev/*

diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -0,0 +1 @@
+npm run lint:js
diff --git a/includes/manager.php b/includes/manager.php
@@ -17,7 +17,7 @@ final class Manager {
 	public static function get_module_list(): array {
 		return [
 			'Legacy',
-			'Settings'
+			'Settings',
 		];
 	}
 

diff --git a/modules/settings/assets/js/hooks/use-auth.js b/modules/settings/assets/js/hooks/use-auth.js
@@ -1,6 +1,5 @@
 import API from '../api';
 import { UPGRADE_LINK } from '../constants';
-import { usePluginSettingsContext } from '../context/plugin-settings-context';
 
 const useAuth = () => {
 	const { subscriptionId } = 123;