Auto select active network #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
This is nice when you open the plug. I am a little hesitant about it switching while it is open, feels almost unintentional. Additionally, in the scenario I am in the menu want to restart one of the items (VPN, eth, wifi, etc) turning it off moves it away and then I need to move back to turn it on. But that is just a single personal opinion.
|
I actually agree with you @zeebok so I will remove that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically select the first device which is in the activated state.
I typically use the wifi connection on my laptop which also has ethernet, as would most folks.
Whenever I open the networking plug, the first device (wired) is pre-selected and I have to do an extra click to select the wifi device to view or make changes.
Now, the wifi gets pre-selected instead, when opening the plug:
If both (or neither) wired and (nor) wireless are activated, then the first (wired) is pre-selected, preserving the current (old) behaviour.
Also, while the plug is open, toggling devices (wired, wireless) updates the selected device.
edit: No longer auto switch while plug is already open.