Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear icon inconsistent #1126

Open
newhoa opened this issue Jul 5, 2022 · 1 comment · May be fixed by #1146
Open

Clear icon inconsistent #1126

newhoa opened this issue Jul 5, 2022 · 1 comment · May be fixed by #1146

Comments

@newhoa
Copy link
Collaborator

newhoa commented Jul 5, 2022

What Happened?

The clear (edit-clear) icons are inconsistent between normal and symbolic variants.

Steps to Reproduce

e-icon-clear-icons

Expected Behavior

These should probably all use the same symbol. Although I'm not sure what to do as the broom looks a little like a paint brush in symbolic form, and the backspace shape is difficult to see when used as a normal icon.

I tried just the backspace style red. This makes it easy to see in dark and light themes, and gives it the "danger/destructive" color.

e-icon-clear-1

But, I do like the broom too. Not sure what would be best here.

OS Version

6.x (Odin)

Software Version

Compiled from git

Log Output

No response

Hardware Info

No response
@danirabbit
Copy link
Member

danirabbit commented Jul 5, 2022 •
edited
Loading

  • Probable the first thing to do would be to GitHub search and see where edit-clear is used and switch all of those instances to edit-clear-all with fallbacks enabled so we ideally don’t break anything.
  • Then we can move edit-clear to edit-clear-all and add a color version of the edit-clear-symbolic metaphor. We can probably re-use the shape from mail-mark-important and just flip it
  • And then we could finish it off by making both the color and symbolic versions of edit-clear-all the same silhouette which should more obviously be a broom or dust brush kind of shape than a paint brush shape

@newhoa newhoa linked a pull request Nov 5, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Actions: Make edit-clear more consistent newhoa/icons
2 participants
@newhoa @danirabbit