Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken generic search (Cltr-K) #2004

Closed
romuald opened this issue Nov 22, 2024 · 1 comment
Closed

Broken generic search (Cltr-K) #2004

romuald opened this issue Nov 22, 2024 · 1 comment
Labels
A-Spotlight-Search The new search dialog available in develop and Nightly O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@romuald
Copy link

romuald commented Nov 22, 2024

Steps to reproduce

When using the "Cltr-K" shortcut to jump to another room, the search window will self-close, unless the user pauses typing after the first character

KO

  • Enter Cltr-K
  • Start typing a person or room's name
  • Search window closes

OK

  • Enter Cltr-K
  • Type the first character of a person / room name
  • Wait for the UX to update (< 1 second)
  • Continue typing, the UX correctly filters the room / people names

Versions

While checking from another computer, and upgrading

  • Version 1.11.86 is KO
  • Version 1.11.80 was OK

Exception

TypeError: Cannot read properties of null (reading 'compareDocumentPosition')
    at f (RovingTabIndex.tsx:95:33)
    at Array.sort (<anonymous>)
    at y (RovingTabIndex.tsx:116:24)
    at Object.ws [as useReducer] (react-dom.production.min.js:163:451)
    at t.useReducer (react.production.min.js:26:114)
    at E (RovingTabIndex.tsx:213:31)
    at fs (react-dom.production.min.js:160:137)
    at Da (react-dom.production.min.js:196:258)
    at El (react-dom.production.min.js:291:88)
    at bc (react-dom.production.min.js:279:389)

Outcome

What did you expect?

To be able to continue typing what I was searching for

What happened instead?

The search window closes, and I'm typing into the current room what I was searching for

Operating system

Linux, macOS

Application version

1.11.86

How did you install the app?

No response

Homeserver

No response

Will you send logs?

Yes

@dosubot dosubot bot added A-Spotlight-Search The new search dialog available in develop and Nightly O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Nov 22, 2024
@t3chguy
Copy link
Member

t3chguy commented Nov 22, 2024

Duplicate of element-hq/element-web#28493

@t3chguy t3chguy marked this as a duplicate of element-hq/element-web#28493 Nov 22, 2024
@t3chguy t3chguy closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spotlight-Search The new search dialog available in develop and Nightly O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants