-
Notifications
You must be signed in to change notification settings - Fork 43
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Run app.setAppPath() with the right path (#78)
* Fix: Run app.setAppPath() with the right path * Implement feedback <3 * test: Add linting
- Loading branch information
1 parent
381ca1a
commit 9a808be
Showing
3 changed files
with
43 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,26 @@ | ||
const path = require('path'); | ||
|
||
if (process.arch === 'arm64') { | ||
process._archPath = require.resolve('../app-arm64.asar'); | ||
setPaths('arm64'); | ||
} else { | ||
process._archPath = require.resolve('../app-x64.asar'); | ||
setPaths('x64'); | ||
} | ||
|
||
function setPaths(platform) { | ||
// This should return the full path, ending in something like | ||
// Notion.app/Contents/Resources/app.asar | ||
const appPath = app.getAppPath(); | ||
const asarFile = `app-${platform}.asar`; | ||
|
||
// Maybe we'll handle this in Electron one day | ||
if (path.basename(appPath) === 'app.asar') { | ||
const platformAppPath = path.join(path.dirname(appPath), asarFile); | ||
|
||
// This is an undocumented API. It exists. | ||
app.setAppPath(platformAppPath); | ||
} | ||
|
||
process._archPath = require.resolve(`../${asarFile}`); | ||
} | ||
|
||
require(process._archPath); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,24 @@ | ||
if (process.arch === 'arm64') { | ||
process._archPath = require.resolve('../app-arm64'); | ||
setPaths('arm64'); | ||
} else { | ||
process._archPath = require.resolve('../app-x64'); | ||
setPaths('x64'); | ||
} | ||
|
||
function setPaths(platform) { | ||
// This should return the full path, ending in something like | ||
// Notion.app/Contents/Resources/app | ||
const appPath = app.getAppPath(); | ||
const appFolder = `app-${platform}`; | ||
|
||
// Maybe we'll handle this in Electron one day | ||
if (path.basename(appPath) === 'app') { | ||
const platformAppPath = path.join(path.dirname(appPath), appFolder); | ||
|
||
// This is an undocumented private API. It exists. | ||
app.setAppPath(platformAppPath); | ||
} | ||
|
||
process._archPath = require.resolve(`../${appFolder}`); | ||
} | ||
|
||
require(process._archPath); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters