Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 180 isn't in 2.1.2, so fails for electron 30. #184

Closed
Kilian opened this issue Mar 11, 2024 · 2 comments
Closed

fix 180 isn't in 2.1.2, so fails for electron 30. #184

Kilian opened this issue Mar 11, 2024 · 2 comments

Comments

@Kilian
Copy link
Member

Kilian commented Mar 11, 2024

The fix for 2.1.2 isn't in the version that's currently on NPM. `dist/src/modules-names.js currently has the following JS:

if (((_b = features === null || features === void 0 ? void 0 : features.isViewApiEnabled) === null || _b === void 0 ? void 0 : _b.call(features)) !== false) {
    exports.browserModuleNames.push('ImageView');
}

Which now breaks on features.isViewApiEnabled again like #179

@Kilian
Copy link
Member Author

Kilian commented Mar 11, 2024

Whelp nevermind, it was a subdepencency.

@Kilian Kilian closed this as completed Mar 11, 2024
@Nantris
Copy link

Nantris commented May 15, 2024

@Kilian do you know what sub-dependency you faced this issue with? It sure seems like @electron/remote to me, but I'm guessing I'm overlooking something in the stack trace given that you got it working.

Whoops, nevermind; we're not fully up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants