Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace or make own electron-windows-store #2104

Closed
3 tasks done
mahnunchik opened this issue Dec 21, 2020 · 11 comments
Closed
3 tasks done

Replace or make own electron-windows-store #2104

mahnunchik opened this issue Dec 21, 2020 · 11 comments

Comments

@mahnunchik
Copy link
Contributor

mahnunchik commented Dec 21, 2020

Preflight Checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

I've faced with the following issues while building AppX app for Windows Store submission:

AppX maker uses electron-windows-store under the hood https://www.electronforge.io/config/makers/appx

Proposed Solution

Replace electron-windows-store by something not dead or make own AppX maker.

Alternatives Considered

Additional Information

@malept
Copy link
Member

malept commented Dec 21, 2020

To be very blunt about it, I am not interested in maintaining electron-windows-store or a fork of it unless I'm consistently sponsored to do so.

That being said, if someone that's relatively trusted in the Node.js/Electron community steps up and maintains a fork, then I'll consider updating the dependency. If it's an entirely new module with a new API, that would require much more work.

I'm closing this for the time being as there's currently no action to be done on the Forge side.

@malept malept closed this as completed Dec 21, 2020
@mahnunchik
Copy link
Contributor Author

😢

@gaetandezeiraud
Copy link

Yes sad :(

@hermit99
Copy link

In my fork, at least #133 #138 were solved

@azchohfi
Copy link

azchohfi commented Dec 8, 2022

Electron-Forge should either move away from electron-windows-store, or electron userland should add new maintainers to https://github.com/electron-userland/electron-windows-store.
I'll try to get in touch with @felixrieseberg.

@erickzhao
Copy link
Member

A bunch of us are maintainers of the @electron-userland org and could make changes if needed.

@azchohfi
Copy link

azchohfi commented Dec 8, 2022

@erickzhao This would be great! Is there a process for electing someone?

@gaetandezeiraud
Copy link

Also, can be usefull to have the option to output an msix file. Now that this is officially the standard way to make an installer for Windows.

@erickzhao
Copy link
Member

I don't think we're actively looking for new maintainers right now but PRs are definitely welcome.

@mmarczell-graphisoft
Copy link

@erickzhao I would advocate for merging some existing PRs:
electron-userland/electron-windows-store#134
electron-userland/electron-windows-store#146

@erickzhao
Copy link
Member

Hey @mmarczell-graphisoft, thank you for bringing those to my attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants