Cannot publish to S3 #143
Comments
|
@noahott You're config object is a little bit off I think Then simply run |
|
I've updated the config as you suggested, but I am still getting the same errors. Running "electron-forge publish" tries to publish to github and fails with an error that the owner and name properties are not defined. Running "electron-forge publish --target=s3" results in the same error "Could not find a publish target with the name: true" |
|
@noahott What is your electron forge version?
|
|
@MarshallOfSound it is 2.8.0. I installed through npm |
|
Oh, this hasn't been released yet |
|
@noahott Just published |
|
I updated to 2.8.1, but now i'm running into a different error during the "preparing native dependencies" stage:
not sure if this is related, but I can't test publishing now without getting this. |
|
It's unrelated and a very strange error. |
|
I can't reproduce the node-gyp error on Linux (64-bit) on a project with a native module. |
|
I was able to solve the node-gyp related error by uninstalling electron-forge and reinstalling using npm. I was able to get publishing setup to S3 with a few caveats. Publishing fails with the folowing error when only the ELECTRON_FORGE_S3_SECRET_ACCESS_KEY environment variable is set:
Publishing only succeeds when BOTH the "secretAccessKey" and "secret" properties are defined in the forge.s3 config. This is not documented anywhere, and doesn't match the instructions in the error message. |
|
That's strange, because there's no reference to a |
|
|
I noticed that using Electron 6 that uses Node.js v12 has a conflict with [email protected]. The S3 publisher has a dependency on "s3" which uses [email protected]. The master branch of the "s3" module has a reference to the version of graceful-fs that works, but they have not published the fix to NPM. Issue: andrewrk/node-s3-client#197 |
|
@gitsome The version of |
Thanks for the response @MarshallOfSound! That's a good point. I could switch versions during publish and avoid the error. I do have nodegit as a dependency in my Electron project though and am trying to build it while on NodeJS 12 in my local system. I'll try to downgrade to NodeJS 10 and see if I can get both nodegit to build succesfully and also avoid the s3 publish issue. Thanks for all your great work! |
|
Electron Forge v6 no longer uses the |
Please describe your issue:
I cannot publish to an S3 target. Publish failing with error: Could not find a publish target with the name: true
I've tried the publish command with and without an explicit --target flag and with various formatting. Leaving off the flag defaults to github which I don't have setup or defined in the config JSON. I get the same error every time.
Console output when you run
electron-forgewith the environment variableDEBUG=electron-forge:*. (Instructions on how to do so here). Please include the stack trace if one exists.What command line arguments are you passing?
What does your
config.forgedata inpackage.jsonlook like?Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using
electron-forge initis a good starting point, if that is not thesource of your problem.
$ electron-forge init
remove github_repository object and add in to forge config:
"publish_targets": {
"s3": {
"accessKey": "XXXX",
"bucket": "XXXX",
"folder": "Releases",
"public": true
}
},
"s3": {
"accessKey": "XXXX",
"bucket": "XXXX",
"folder": "Releases",
"public": true
}
$ electron-forge publish --target=s3
The text was updated successfully, but these errors were encountered: