Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: Release Notes V2 #30516

Closed
3 tasks
MarshallOfSound opened this issue Aug 13, 2021 · 4 comments
Closed
3 tasks

Project: Release Notes V2 #30516

MarshallOfSound opened this issue Aug 13, 2021 · 4 comments
Labels

Comments

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Aug 13, 2021

One of the big issues folks have with upgrading Electron is being able to easily tell (a) what has changed between the version they're on and the version they're upgrading to and (b) whether those changes impact them.

Currently the solution to (a) is to check the releases notes of every version between vCurrent and vNext. This works reasonably well for upgrades within the same major version of Electron but falls apart when crossing the major version boundary. This is because fixes / features in vN might not be in vN+1 and vice versa due to how we maintain branches in parallel and backport changes.

In order to solve this problem in a way that actually solves the underlying issue for electron app developers I'd like to outline a series of changes to how we handle release notes.

  • Release notes should not be included in GitHub releases, the notes are inaccurate best and completely wrong at worst.
  • The release notes generation code should be pulled out of electron/electron and moved to clerk such that you can fire an API request and obtain release notes between two versions.
  • GitHub Releases should contain links to a new release notes service on https://releases.electronjs.org powered by the Clerk release notes service

The new release notes service in clerk is specced out here: electron/clerk#66

@nornagon
Copy link
Member

fixes / features in vN might not be in vN+1

This seems like a failure of our backporting policy IMO. Upgrading should never remove features (unless those features were intentionally removed & the removal was listed in breaking changes, etc.)

@MarshallOfSound
Copy link
Member Author

MarshallOfSound commented Aug 13, 2021

This seems like a failure of our backporting policy IMO. Upgrading should never remove features (unless those features were intentionally removed & the removal was listed in breaking changes, etc.)

Not necessarily, our version system is non-linear, such that 13.3.0 might contain fixes not in 14.0.1 literally because it was released after it. I.e. the change might be in 14.2.0 🤷 It isn't a failure in backport policy, it's just an unchangeable That's How Time Works problem 😄

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants