Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The code introduces the exe-icon-extractor package inconsistently with the package.json definition #167

Open
Sallyfafafa opened this issue Jun 13, 2023 · 1 comment
Open

The code introduces the exe-icon-extractor package inconsistently with the package.json definition #167

Sallyfafafa opened this issue Jun 13, 2023 · 1 comment

Comments

@Sallyfafafa
Copy link

The definition uses the @bitdisaster/exe-icon-extractor：
https://github.com/electron-userland/electron-wix-msi/blob/master/package.json#L36

The source code uses the exe-icon-extractor
https://github.com/electron-userland/electron-wix-msi/blob/master/src/utils/rc-edit.ts#L22

When I use electron-wix-msi to build a windows application, I get a message that exe-icon-extractor cannot be found

Can we standardize?
@dineshmedloop
Copy link

any solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sallyfafafa @dineshmedloop