spellCheckHandler.attachToInput breaks on electron 5.0.0 #144
Comments
|
I'm working on fixing this. Will have a fork + PR up soon. |
Starting with Electron 5.0.0, the function `webFrame.setSpellCheckProvider` has a different signature, in order to support asynchronous spell checkers. For more information on this change in Electron, see electron/electron#14032. This diff updates `SpellCheckHandler` to use the new interface if running on Electron 5.0.0 and above. However, it still checks the spelling synchronously like before. If running on Electron versions below 5.0.0, the `SpellCheckHandler` still works. Closes electron-userland#144.
Starting with Electron 5.0.0, the function `webFrame.setSpellCheckProvider` has a different signature, in order to support asynchronous spell checkers. For more information on this change in Electron, see electron/electron#14032. This diff updates `SpellCheckHandler` to use the new interface if running on Electron 5.0.0 and above. However, it still checks the spelling synchronously like before. If running on Electron versions below 5.0.0, the `SpellCheckHandler` still works. Closes electron-userland#144.
|
@robsonhermes and @smithalan92, I've created a branch and PR to fix this. If you're still interested, could you try the change in your environments and/or provide feedback? The branch is mlalkaka/electron-spellchecker. |
|
@mlalkaka will try that in my first open slot and update you here. Many thanks! |
|
Thats great @mlalkaka , I gave that a test using Electron v5 and it works nicely 👌 Hopefully @felixrieseberg will have some time to approve the PR and deploy a new version |
|
Hm, I had the problem below. Source code of my test is robsonhermes/electron-spellchecker-test Just mind package.json, I used "electron-spellchecker": "0.0.1", cause this is how I built/published it locally. Did I miss anything? Not sure if this is somehow related to issue 148.
|
|
Fixed and released as 2.1.0 🙇 |
|
Still not working for me. Could anyone please tell me if you had the same problem? https://github.com/robsonhermes/electron-spellchecker-test results in the error I posted in my last msg. |
|
Your example works fine for me @robsonhermes ( I'm on MacOS though ) |
|
Just tried on Linux (Ubuntu). fails with the same error. But I guess it´s not related to this fix. Thanks for trying it out, @smithalan92 |
|
@robsonhermes, sorry for the late reply here. I've been trying to repro
this on Windows, but have been having unrelated troubles with my Windows
PC. I'll give this another try later today.
…On Thu, Jun 13, 2019, 6:20 AM Robson Hermes ***@***.***> wrote:
Just tried on Linux (Ubuntu). fails with the same error. But I guess it´s
not related to this fix.
Will open a separate issue.
Thanks for trying it out, @smithalan92 <https://github.com/smithalan92>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#144?email_source=notifications&email_token=ACZ6REJ6PYRBUGRKG4NDULTP2JCRNA5CNFSM4HJLEMQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXTVHYY#issuecomment-501699555>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACZ6REKGTI36GEYYAWQBCMLP2JCRNANCNFSM4HJLEMQA>
.
|
Hello
Starting from Electron 5.0.0, the method
spellCheckHandler.attachToInputbreaks with:I guess this happens cause parameters of method
webFrame.setSpellCheckProviderchanged in version 5.0.0 -> link.The text was updated successfully, but these errors were encountered: