Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - _Observable.Observable.merge is not a function #122

Open
smithalan92 opened this issue Sep 11, 2018 · 2 comments
Open

Windows - _Observable.Observable.merge is not a function #122

smithalan92 opened this issue Sep 11, 2018 · 2 comments

Comments

@smithalan92
Copy link

When running an build electron app on Windows, I get the following error

_Observable.Observable.merge is not a function

The line of code in question is this one https://github.com/electron-userland/electron-spellchecker/blob/master/src/spell-check-handler.js#L245

The distributable lib looks like

var _Observable = require('rxjs/Observable');
...
disp.add(_Observable.Observable.merge(this.spellCheckInvoked, this.currentSpellcheckerChanged).subscribe(() => wordsTyped = 0));

On MacOS it works fine, because It seems the above code is not executed.

I'm not familar with RxJS, but looking at the imports here https://github.com/electron-userland/electron-spellchecker/blob/master/src/spell-check-handler.js#L10-L14 , is it possible that an import for a 'merge' lib is missing?

@chrisknepper
Copy link

@smithalan92 Yep, I got the same problem. I'm using this spellchecker in a personal project and found it would either fail to build or just not work as in #128 . This seems to be happening because of an upstream issue with rxjs and that project changing its exports without a proper semantic version change. You should be able to build/get it working on Windows by changing that line in spell-check-handler.js (in the distributable or lib folder) to var _Observable = require('rxjs');

@chrisknepper
Copy link

Seems related to ReactiveX/rxjs#1694

alexstrat added a commit to getstation/electron-spellchecker that referenced this issue Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants