-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Racing issue on concurrent read #186
Comments
Need either to patch the original lockfile lib (which the owner already archived it), or probably should fork that lib and fix this issue. |
Hm, it might make sense to vendor |
Given that we need to patch lockfile and such project is currently archived. See: #186 Signed-off-by: Juan Cruz Viotti <[email protected]>
OK, I vendored the module here: #187. What is the patch you need on |
During concurrent read it crashes on lockfile library.
It seems that the lockfile lib that this lib reference has a bug
https://github.com/npm/lockfile/blob/6590779867ee9bdc5dbebddc962640759892bb91/lockfile.js#L286
Notice that this line
var st = fs.statSync(path)
When it tries to read the path, the lock file is already being deleted by another concurrent read. Thus this line will throw and there is no catch. As a result this line crash with the following exception:
The text was updated successfully, but these errors were encountered: