Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async 2.0 has vulnerable issue #177

Open
garasubo opened this issue Apr 14, 2022 · 3 comments · May be fixed by #178
Open

async 2.0 has vulnerable issue #177

garasubo opened this issue Apr 14, 2022 · 3 comments · May be fixed by #178

Comments

@garasubo
Copy link

async 2.0 includes vulnerability (GHSA-fwr7-v2mv-hh25).
I looked into the usage of async library in this project, and it looked this project didn't use the vulnerable method. However, this caused warning message from npm both in this project and projects using this library.

It will be nice to update >= 3.2.2. There are some breaking changes, but I think it won't affect this project.
@garasubo garasubo linked a pull request Apr 14, 2022 that will close this issue
Open
@garasubo
Copy link
Author

@jviotti Any update on this? #176 or #178 will resolve this issue.

@jviotti
Copy link
Member

jviotti commented Apr 23, 2022

Thanks @garasubo! The PRs look good, but Travis CI is not kicking-in for this repo for some reason. I'll see if I can make it work. I don't have admin permissions on this repo though, so we will have to contact an admin if I cannot resolve it.

@jviotti
Copy link
Member

jviotti commented Apr 23, 2022

See electron-userland/welcome#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update async version garasubo/electron-json-storage
2 participants
@jviotti @garasubo