Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

Playground UI #157

Closed
saurabhdaware opened this issue Sep 27, 2019 · 9 comments
Closed

Playground UI #157

saurabhdaware opened this issue Sep 27, 2019 · 9 comments

Comments

@saurabhdaware
Copy link
Contributor

We can start off by adding css to the existing playground. Let's have a discussion here about the UI design.

@ovbm
Copy link
Contributor

ovbm commented Sep 27, 2019

Hey there, yes, I think the styling needs to be improved. I'd like to couple this with #161 . Also we could think about working with a component library or a UI framework to make the code easy to maintain and collaborate.
Material UI is very well maintained and stable: https://material-ui.com/

@ovbm ovbm closed this as completed Sep 27, 2019
@ovbm ovbm reopened this Sep 27, 2019
@ovbm
Copy link
Contributor

ovbm commented Sep 27, 2019

didn't mean to close ^^

@saurabhdaware
Copy link
Contributor Author

What are the features that we're going to have in the playground (apart from the ones that exist right now?)

If you want something lightweight then I think Preact or Svelte can be good options as well or we can even think of just staying vanilla (if we just want to replicate the existing features)

@ovbm
Copy link
Contributor

ovbm commented Sep 27, 2019

There are two main features we want to prioritize:

could be done vanilla, just thinking about the future really.

@ovbm
Copy link
Contributor

ovbm commented Sep 27, 2019

i'm going to be implementing react ASAP so we can use things like react-table and other useful components.

@saurabhdaware
Copy link
Contributor Author

Yeah I think react will be better in the long run (specially for something like #160 ).

You can let me know if there is anything I can help with.

@ovbm
Copy link
Contributor

ovbm commented Sep 30, 2019

React transition is done, UI is still very crude, but If you want to have a go, feel free to make suggestions. The table component could be paginated for example.

@saurabhdaware
Copy link
Contributor Author

Cool, I'll check it out. Also, there are some dependencies which are mentioned in babel-config but are not mentioned in package.json so they were throwing errors when I followed installation step. I've added them to package.json and I'll create PR in some time.

@martincollignon
Copy link
Contributor

closing due to inactivity. A couple of improvements have already been made. @madsnedergaard @corradio

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants