Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param ordering inconsistent with Electric client. #454

Closed
thruflo opened this issue Dec 3, 2024 · 3 comments
Closed

Param ordering inconsistent with Electric client. #454

thruflo opened this issue Dec 3, 2024 · 3 comments

Comments

@thruflo
Copy link
Contributor

thruflo commented Dec 3, 2024

Electric recently merged electric-sql/electric#2044 to consistent sort query params to maximise cache hits. I have an example app with pure Electric and PGlite components in the same page. I noticed that the PGlite sync requests have params in a different order to the pure Electric requests:

image

I'm aware that I'm using electric from the ppm workspace and PGlite as a versioned deployment:

"@electric-sql/client": "workspace:*",
"@electric-sql/pglite": "^0.2.14",
"@electric-sql/pglite-react": "^0.2.14",
"@electric-sql/pglite-sync": "^0.2.16",
"@electric-sql/react": "workspace:*",

So this may just be a versioning thing but I'm guessing the PGlite sync doesn't use the Typescript client under the hood (or does it)?

@samwillis
Copy link
Collaborator

It does use the code Electric client internally, so I suspect this is version thing... we'll double check. It's probably bringing in the published version with then runs in parallel along side the workspace one.

@KyleAMathews
Copy link
Contributor

The change hasn't been released yet

electric-sql/electric#2046

@thruflo
Copy link
Contributor Author

thruflo commented Dec 3, 2024

Ok great 👍

@thruflo thruflo closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants