examples: add gatekeeper-auth example. #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thruflo
changed the title
thruflo
commented
Nov 11, 2024
| scope "/gatekeeper" do | ||
| pipe_through :gatekeeper | ||
|
|
||
| post "/:table", Electric.Phoenix.Gateway.Plug, client: &Authenticator.client/0 |
There was a problem hiding this comment.
@magnetised the client syntax / concept isn't the most obvious here. It's great that we can technically pass in an Authenticator via the client option. However the reason to be using a "client" in this context isn't super obvious. I'd much rather write e.g.:
post "/:table", Electric.Phoenix.Gateway.Plug, authenticator: {MyAuthenticator, []}Or even just the function that generates the auth headers:
post "/:table", Electric.Phoenix.Gateway.Plug, auth_headers: &MyAuthenticator.authenticate_shape/2Following the thought, that Authenticator.authenticate_shape/2 function gets the shape and a config options keyword list. It doesn't get the conn. Which, when generating an auth token, might be useful context, for example to put a user_id in the token, etc.
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thruflo
changed the title
thruflo
changed the title
kevin-dp
reviewed
Nov 14, 2024
thruflo
force-pushed
the
thruflo/gatekeeper-auth-example
branch
from
586fbda to
8c20344
Compare
Examples |
thruflo
had a problem deploying
to
Pull request
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/electric-sql/electric/tree/thruflo/gatekeeper-auth-example/examples/gatekeeper-auth -- the example folder and subfolders all have READMEs.
I haven't yet updated the auth guide. I suspect it's best to merge this and update the guide in a separate PR.