fix: Log error without falling over for failed recovery #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we don't "recover" the shape — what happens if someone requests it? |
|
@KyleAMathews as far as electric is concerned, the shape does not exist - it just leaves the data on disk rather than cleaning it up (and thus will try to recover it on a subsequent deploy again) So effectively it's abandoning a shape but leaving it on disk, either for manual cleanup or if we figure out the issue and it's not actually corrupted data it can be restored. |
robacourt
approved these changes
Nov 26, 2024
|
@msfstef cool then leaving it seems fine — presumably we'll either figure a fix or just move off cubdb making the problem moot). |
msfstef
added a commit
that referenced
this pull request
Nov 27, 2024
Followup to #2049 We are currently leaving folders behind when deleting shapes, which do take up a little bit of space and eventually could be a bit of an issue. This PR takes care of removing everything. Additionally, when a shape fails to recover by not being able to start the consumer at all (see CubDB issue), the shape data is removed using a new method called `unsafe_cleanup!` which simply `rm -rf`s the shape directory. Not great to use while the shape is active as it can cause various bugs, but great for cleaning up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen some issues related to lucaong/cubdb#71 come up during recovery, and it currently causes issues with the whole electric.
Initially my thought was to delete the shape entirely if it fails, but perhaps as an initial workaround we might just want to log the error and continue recovery without the problematic shape?