Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed website builds #2002

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore: fixed website builds #2002

merged 1 commit into from
Nov 20, 2024

Conversation

icehaunter
Copy link
Contributor

@icehaunter icehaunter commented Nov 20, 2024

Previous matching was generating wrong blog structure (paths were split on arbitrary -), which led to "dead link" complaints. Also the .split of the path was wrong because preceding slash is not part of the file, but maybe that's incosistent between mac & linux so I replaced it with a definitely crossplatform call

@icehaunter icehaunter requested a review from thruflo November 20, 2024 11:43
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit 0cccf74
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/673dcb638496bb0007f26748
😎 Deploy Preview https://deploy-preview-2002--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@balegas balegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock it since it builds and work, but if anything sensitive better to raise with @thruflo

@icehaunter icehaunter merged commit c2fbea1 into main Nov 20, 2024
6 checks passed
@icehaunter icehaunter deleted the ilia/fix-website-builds branch November 20, 2024 12:07
@thruflo
Copy link
Contributor

thruflo commented Nov 20, 2024

I had already fixed this in #1988 -- waiting on a review for a while now.

It was worth waiting for me to input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants