fix(@electric-sql/client): The table option isn't required as a team using a proxy API might set the table there #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using a proxy API might set the table there
thruflo
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Note that the options type is duplicated here https://electric-sql.com/docs/api/clients/typescript#options
(Would be nice to include this from the source. I couldn’t see a way to do this easily. Perhaps we could script it at build time).
(I.e it’s easy to include whole files, but not partial files, neither by line numbers nor definitions. An alt approach might be to extract out definitions like this to their own files. But that’s a bit tail wagging the dog.)
|
Ah right — thanks! |
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kevin-dp
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.