Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename env variables so consitently prefixed with ELECTRIC_ #1928

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

KyleAMathews
Copy link
Contributor

Fix #1927

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit 19459de
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/672a1fd35f375400085166ec
😎 Deploy Preview https://deploy-preview-1928--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thruflo
Copy link
Contributor

thruflo commented Nov 5, 2024

I think it would be useful to do this on top of the new deployment guide, given that has a new page documenting the env var config.

@KyleAMathews
Copy link
Contributor Author

Is that going in right now too? This is another breaking change so I want it to go out with all the others (ideally today)

@KyleAMathews
Copy link
Contributor Author

Happy to pr the updates separately to the doc page

@KyleAMathews
Copy link
Contributor Author

ok merging and then I'll open a PR to the docs PR with the same updates

@KyleAMathews KyleAMathews merged commit 0873da2 into main Nov 5, 2024
23 checks passed
@KyleAMathews KyleAMathews deleted the rename-env-vars branch November 5, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistently Namespace our Environment Variables with ELECTRIC_
3 participants