-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: move table to query param & rename existing headers and query params #1900
Conversation
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
343b52c
to
1d0ed6f
Compare
Btw, I don't understand why the typecheck tests are failing.
|
@thruflo the |
Yup, I've I'm not really the right person to revise the way we run our CI tests :) |
@thruflo I was also seeing the same issue - typecheck passed locally but failed on CI, and the lines referenced on CI for the errors did not match the actual test file, so something odd happening there... There's a conflict now so tests aren't running though. |
ba5ec88
to
8261b25
Compare
@msfstef fixed the conflict. |
@thruflo types fixed 💪 🚀 |
7486f2d
to
4d92d2b
Compare
See https://deploy-preview-1892--electric-next.netlify.app/docs/guides/writing-your-own-client The URL format and headers have been updated to match the latest in #1900
Included renames:
electric-chunk-last-offset
->electric-offset
electric-next-cursor
->electric-cursor
electric-shape-id
->electric-handle
?shape_id
->?handle
Added query parameter:
?table
instead of/:table
in the pathCloses #1771, #1796, #1798