Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags for NPM releases aren't consistently created #1578

Open
KyleAMathews opened this issue Aug 27, 2024 · 3 comments
Open

Tags for NPM releases aren't consistently created #1578

KyleAMathews opened this issue Aug 27, 2024 · 3 comments
Assignees
Labels

Comments

@KyleAMathews
Copy link
Contributor

@alco investigated and "there seems to be a race condition in the publishing action where it first publishes to npm, then checks the version published to npm and based on the fact that the published and local versions are the same, it skips tag creation."

@balegas
Copy link
Contributor

balegas commented Dec 3, 2024

is this still an issue?

@KyleAMathews
Copy link
Contributor Author

Yup
Screenshot 2024-12-03 at 9 25 10 AM

https://github.com/electric-sql/electric/actions/runs/12143824497/job/33861640016

If you restart it it does seem to generally work the second time. The problem is that @electric-sql/react tries to be published before @electric-sql/client has been published so it fails as react depends on client.

@balegas
Copy link
Contributor

balegas commented Dec 17, 2024

Assigned to @icehaunter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants