Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Rise In bootcamp community repos #771

Closed
wants to merge 0 commits into from
Closed

Adding Rise In bootcamp community repos #771

wants to merge 0 commits into from

Conversation

Rise-In
Copy link
Contributor

@Rise-In Rise-In commented Dec 21, 2023

No description provided.

@Rise-In
Copy link
Contributor Author

Rise-In commented Dec 21, 2023

Adding Rise In bootcamp community repos

3 similar comments
@Rise-In
Copy link
Contributor Author

Rise-In commented Dec 21, 2023

Adding Rise In bootcamp community repos

@Rise-In
Copy link
Contributor Author

Rise-In commented Dec 21, 2023

Adding Rise In bootcamp community repos

@Rise-In
Copy link
Contributor Author

Rise-In commented Dec 21, 2023

Adding Rise In bootcamp community repos

eherrerosj
eherrerosj suggested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good first step, needs some work, left some comments. There quite a few URLs that need the right formatting

data/ecosystems/b/bnb-chain-bsc.toml Outdated
url = "https://github.com/Tejaswini262004/CS50-Final-Project"

[[repo]]
url = "https://gist.github.com/arhansuba/86f62231d8d26350734bd929b44e0603"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a crypto repo

data/ecosystems/b/bnb-chain-bsc.toml Outdated
url = "https://github.com/kaankacar/PTK-Staking-App-For-Patika"

[[repo]]
url = "https://github.com/14metehan53/bnb-chain-final-project/tree/master"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix this kind of URLs, format should be "https://github.com/org/repo"

data/ecosystems/b/bnb-chain-bsc.toml Outdated
url = "https://github.com/srhtdmrkl/smart-tenders"

[[repo]]
url = "https://github.com/Feyzanur25/blokchain/blob/main/smart_contract_frontend/package-lock.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong URL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the return. Links will be updating

data/ecosystems/b/bnb-chain-bsc.toml Outdated
@@ -18171,9 +18168,6 @@ url = "https://github.com/GulfCoinOfficial/gulf-token-smartContract"
[[repo]]
url = "https://github.com/guneyee/BNB-Chain-Safe-Smart-Contract-Frontend"

[[repo]]
url = "https://github.com/guneyee/Safe-Smart-Contract-on-BNB-Chain"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete this URL?

data/ecosystems/b/bnb-chain-bsc.toml Outdated
@@ -2273,9 +2273,6 @@ missing = true
[[repo]]
url = "https://github.com/AhmedSalikRiaz/NFT_marketplace_using_React_and_Moralis"

[[repo]]
url = "https://github.com/ahmetenesdur/chat-dapp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete this URL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We noticed some duplicate repos and removed them

@Rise-In
Copy link
Contributor Author

Rise-In commented Dec 21, 2023

Adding Rise In bootcamp community repos and removing duplicate links

@eherrerosj
Copy link
Contributor

Adding Rise In bootcamp community repos and removing duplicate links

Don't forget fixing this kind of malformed URLs

@Rise-In
Copy link
Contributor Author

Rise-In commented Dec 22, 2023

Removed empty repo links for BNB Chain and corrected incorrect links

@Rise-In
Copy link
Contributor Author

Rise-In commented Dec 22, 2023

Our branches are out of date, should we send a new request for these updates?

@eherrerosj
Copy link
Contributor

Our branches are out of date, should we send a new request for these updates?

You could do that or manually solve the conflicts. In any case I'm still seeing incorrect links and repos that shouldn't be deleted. Let me know when you work on those and I'll do another review. Thanks!

@Rise-In Rise-In closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eherrerosj eherrerosj Awaiting requested review from eherrerosj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rise-In @eherrerosj