Introduce the JsonlParser::fromFile() helper

elecena · Nov 29, 2023 · c6ba82d · c6ba82d
1 parent ec76635
commit c6ba82d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/JsonlParser.php b/src/JsonlParser.php
@@ -13,6 +13,15 @@ public function __construct(protected $stream)
     {
     }
 
+    /**
+     * Initialize the parser from the given file.
+     */
+    public static function fromFile(string $filename, string $mode = 'a+t'): self
+    {
+        $stream = fopen($filename, $mode);
+        return new self($stream);
+    }
+
     public function push(array|string $item): void
     {
         $encoded = json_encode($item);

diff --git a/tests/JsonParserTest.php b/tests/JsonParserTest.php
@@ -127,13 +127,11 @@ public function testPushItemsToFile(): void
         fclose($stream); // this removes the file
     }
 
-    public function testFileSyncing(): void
+    public function testFromFile(): void
     {
         $tmpFilename = tempnam(directory: sys_get_temp_dir(), prefix: 'jsonld');
-        $stream = fopen($tmpFilename, 'a+t');
 
-        // TODO: introduce a helper JsonlParser::fromFile()
-        $parser = new JsonlParser($stream);
+        $parser = JsonlParser::fromFile($tmpFilename);
         $this->assertCount(0, $parser);
         $this->assertTrue($parser->empty());
 
@@ -166,7 +164,6 @@ public function testFileSyncing(): void
             actualString: ''
         );
 
-        fclose($stream);
         unlink($tmpFilename);
     }
 }