Fixed connection cloning (#20)

elasticio · Mar 27, 2023 · 9c862f0 · 9c862f0
1 parent d727743
commit 9c862f0
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 1.4.1 (March 27, 2023)
+Fixed connection cloning in `Publish` action
+
 ## 1.4.0 (March 25, 2023)
 * Implemented retry mechanism on connection errors
 * Added configuration fields to set retry options

diff --git a/component.json b/component.json
@@ -1,7 +1,7 @@
 {
   "title": "AMQP component",
   "description": "AMQP Component for async communication with queues and topics",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "credentials": {
     "fields": {
       "amqpURI": {

diff --git a/lib/actions/publish.js b/lib/actions/publish.js
@@ -4,7 +4,11 @@ const { AMQPClient } = require('../amqp.js');
 let amqpClient;
 
 async function processAction(msg, cfg) {
-  if (!amqpClient || !amqpClient.connection) { amqpClient = new AMQPClient(cfg, this); }
+  if (!amqpClient || !amqpClient.connection) {
+    amqpClient = new AMQPClient(cfg, this);
+    await amqpClient.init();
+  }
+
   amqpClient.setLogger(this.logger);
 
   let data;

diff --git a/lib/amqp.js b/lib/amqp.js
@@ -88,7 +88,6 @@ class AMQPClient {
   }
 
   async publish(routingKey, content, options) {
-    await this.init();
     this.logger.info('Going to publish message');
     await this.channel.publish(this.cfg.topic, routingKey, content, options);
     this.logger.info('Message published');

diff --git a/spec/actions/publush.spec.js → spec/actions/publish.spec.js b/spec/actions/publush.spec.js → spec/actions/publish.spec.js
@@ -26,6 +26,7 @@ describe('processAction', () => {
     const configuration = {
       doNotEncrypt: true,
     };
+    sinon.stub(AMQPClient.prototype, 'init').callsFake(async () => { });
     const publishStub = sinon.stub(AMQPClient.prototype, 'publish').callsFake(async () => { });
     const result = await process.call(getContext(), message, configuration);
 
@@ -49,6 +50,7 @@ describe('processAction', () => {
         routingKey: 'test',
       },
     };
+    sinon.stub(AMQPClient.prototype, 'init').callsFake(async () => { });
     const publishStub = sinon.stub(AMQPClient.prototype, 'publish').callsFake(async () => { });
     const result = await process.call(getContext(), message, {});