-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support configurable chunk size #944
feat: support configurable chunk size #944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of our team but because Vignesh already reviewed and approved. We will fix this repo so his approval is enough (but keep our team as possible reviewers too, even if we have to create a new GH team to achieve this)...
I think its because I pushed a change. |
@dominiqueclarke If you can squash my commit along with yours and remove mine using rebase, We can get this merged faster. |
@vigneshshanmugam are you the only one who can approve PRs for merge in this repo? |
73d092f
to
1169efb
Compare
Adds an environment variable to configure chunk size when pushing monitors to Kibana.
Testing
npm install
thennpm run build
.CHUNK_SIZE=1 SYNTHETICS_API_KEY=MXhmQURwRUI1UGtRakt5TW5zWk46VWtFTWJrbE9RMjZTdFBrRVpFd190Zw== npm run push