Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tools pkg to version control our build dependencies #81

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

andrewkroh
Copy link
Member

Add a tools.go file that contains imports for the build tools that are used from the Makefile. This helps ensure we have reproducible builds.

I'm not worried about bloat in go.mod because this package is not a library (we should adopt internal/ for the code).

@andrewkroh andrewkroh marked this pull request as draft March 21, 2024 15:10
Add a tools.go file that contains imports for the build tools
that are used from the Makefile. This helps ensure we have
reproducible builds.

I'm not worried about bloat in go.mod because this package
is not a library (we should adopt internal/ for the code).
@elasticmachine
Copy link

💚 Build Succeeded

History

@andrewkroh andrewkroh marked this pull request as ready for review March 21, 2024 15:35
@andrewkroh andrewkroh requested a review from a team March 21, 2024 15:36
@andrewkroh andrewkroh merged commit 5033548 into elastic:main Mar 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants