Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main Gemfile logstash-core version constrains #4244

Closed
colinsurprenant opened this issue Nov 20, 2015 · 4 comments
Closed

main Gemfile logstash-core version constrains #4244

colinsurprenant opened this issue Nov 20, 2015 · 4 comments
Labels

Comments

@colinsurprenant
Copy link
Contributor

Related to #4243 and #4236.

Currently in the 2.0 tag and in the 2.1 release branch we pin logstash-core to a specific version, for example (= 2.0.0) and not a range (> 2.0.0, < 3.0.0) nor a pessimistic version (~> 2.0).

See

  • 2.0 tag gem "logstash-core", "2.0.0"
  • 2.1 branch gem "logstash-core", "2.1.0.snapshot3"

The problem is see with this is that it will prevent upgrading logstash-core if we need to, either specifically or but updating/installing a plugin which could depend on a newer version of logstash core.

I think that for released packages we should use the pessimistic versions constrain, for example in 2.0 we could use ~> 2.0. This will allow installing future updated logstash-core versions and exclude prereleases which we typically don't want in a released package.

Thoughts?

@ph
Copy link
Contributor

ph commented Nov 20, 2015

Well, this could have solved the problem of concurrent-ruby, since we would have been able to release a core not link on a specific version.

@colinsurprenant
Copy link
Contributor Author

it is too late for such a change for 2.1, let's followup for post 2.1 releases.

@ph
Copy link
Contributor

ph commented Mar 11, 2016

Can we close this issue ?
I think #4236 is enough to track the problem?

@colinsurprenant
Copy link
Contributor Author

agree, let's focus on #4236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants