You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, when the links_table.yml file is changed all packages are tested. There should be some testing for all packages, at a minimum that the docs are correctly generated after the change, but correct functioning of all packages is onerous and can result in failures that the codeowner of the change cannot easily fix due to ownership or domain expertise, thus blocking the merge (for example #7385).
A possible approach to this would be to only run package checks on all packages in the case that this file changes. Finer-grained approachs would be to only check packages that make use of the file or even that make use of changed links in the file, though checks are relatively cheap and this may not be worth the effort.
The text was updated successfully, but these errors were encountered:
Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!
Currently, when the links_table.yml file is changed all packages are tested. There should be some testing for all packages, at a minimum that the docs are correctly generated after the change, but correct functioning of all packages is onerous and can result in failures that the codeowner of the change cannot easily fix due to ownership or domain expertise, thus blocking the merge (for example #7385).
A possible approach to this would be to only run package checks on all packages in the case that this file changes. Finer-grained approachs would be to only check packages that make use of the file or even that make use of changed links in the file, though checks are relatively cheap and this may not be worth the effort.
The text was updated successfully, but these errors were encountered: