Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make testing more surgical when changes to links_table.yml are made #8077

Open
efd6 opened this issue Oct 3, 2023 · 1 comment
Open

Comments

@efd6
Copy link
Contributor

efd6 commented Oct 3, 2023

Currently, when the links_table.yml file is changed all packages are tested. There should be some testing for all packages, at a minimum that the docs are correctly generated after the change, but correct functioning of all packages is onerous and can result in failures that the codeowner of the change cannot easily fix due to ownership or domain expertise, thus blocking the merge (for example #7385).

A possible approach to this would be to only run package checks on all packages in the case that this file changes. Finer-grained approachs would be to only check packages that make use of the file or even that make use of changed links in the file, though checks are relatively cheap and this may not be worth the effort.

@botelastic
Copy link

botelastic bot commented Oct 2, 2024

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 2, 2024
@efd6 efd6 removed the Stalled label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant