[Logging] Refactor ESLoggerUsageChecker

[tumile]

Refers to #49087

This is a draft PR to refactor ESLoggerUsageChecker, a static analysis tool to verify correct usages of logger. Here are the steps taken to improve the structure of the code

• move WrongLoggerUsage class into its own file

• move ClassChecker into its own file

• move MethodChecker into its own file, along with all static Type since this is the only place they are referenced

• move all BasicValue and BasicInterpreter subclasses into MethodChecker.java as well since they are not used anywhere else

• Inside MethodChecker.java

• refactor findBadLoggerUsages, which is where the bulk of checks are

  • make lineNumber, methodNode, instructions, logMessageFrames, arraySizeFrames instance variables since they are accessed in multiple methods and avoid passing around too much
  • findBadLoggerUsages is broken down to 2 methods
    • analyzeMethod to populate instructions, logMessageFrames, arraySizeFrames
    • walkInstructions to check each instructions
  • walkInstructions checks for Opcode and call verifyMethodUsage or verifyConstructorUsage with necessary arguments
  • verifyMethodUsage is renamed from old verifyLoggerUsage
  • verifyConstructorUsage is extracted from old findBadLoggerUsages
  • the above two will in turn call checkFixedArityArgs or checkArrayArgs
  • the rest is kept semantically the same

• fix SonarLint warnings

[tumile]

Pinging @pgomulka

[pgomulka]

ok to test

[pgomulka]

hey @tumile
thank you for your interest in Elasticsearch, but I will have to close this PR for the time being. As I mentioned in #49087 (comment) the expectation was to discuss possible solutions first, before making refactoring.
I was hoping that there is a 3rd party lib that would achieve what we do there. The refactoring itself would require a fairly complex DSL, possibly migrating to a different byte manipulation library.

[tumile]

Thanks for letting me know. I misunderstood the requirement there. Will be more careful next time!