Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] Extend Lint Checks to Include All Examples for Full Validation #6052

Closed
pkoutsovasilis opened this issue Nov 18, 2024 · 1 comment · Fixed by #6060
Closed

[helm] Extend Lint Checks to Include All Examples for Full Validation #6052

pkoutsovasilis opened this issue Nov 18, 2024 · 1 comment · Fixed by #6060
Assignees
Labels
bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@pkoutsovasilis
Copy link
Contributor

The current helm lint check in our CI pipeline is insufficient. While helm template may pass, helm lint can still fail due to additional validation that helm template does not perform. We should extend the Helm lint checks to validate all the examples in the Helm chart to ensure consistency and prevent errors during deployment.

Example helm/helm#7756 (comment)

  • Steps to Reproduce:
    1. Run helm template ./deploy/helm/elastic-agent -f ./deploy/helm/elastic-agent/examples/kubernetes-default/agent-kubernetes-values.yaml and observe that it passes.
    2. Run helm lint ./deploy/helm/elastic-agent -f ./deploy/helm/elastic-agent/examples/kubernetes-default/agent-kubernetes-values.yaml on the same chart and notice that it fails, demonstrating inconsistencies.
@pkoutsovasilis pkoutsovasilis added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Nov 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants