Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error.stack_trace #562

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Add error.stack_trace #562

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a752dca
Add error.stack_trace
felixbarny Sep 16, 2019
acd0c48
Update PR number in changelog
felixbarny Sep 16, 2019
4e61af8
Make error.stack_trace extended
felixbarny Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Thanks, you're awesome :-) -->
### Bugfixes

### Added
* Added `error.stack_trace` field. #562

### Improvements

Expand Down
3 changes: 3 additions & 0 deletions code/go/ecs/error.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions docs/field-details.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,6 +1014,17 @@ type: text



| core

// ===============================================================

| error.stack_trace
| The stack trace of this error in plain text.

type: keyword



| core

// ===============================================================
Expand Down
5 changes: 5 additions & 0 deletions generated/beats/fields.ecs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,11 @@
level: core
type: text
description: Error message.
- name: stack_trace
level: core
type: keyword
ignore_above: 1024
description: The stack trace of this error in plain text.
- name: event
title: Event
group: 2
Expand Down
1 change: 1 addition & 0 deletions generated/csv/fields.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ ecs.version,keyword,core,1.0.0,1.2.0-dev
error.code,keyword,core,,1.2.0-dev
error.id,keyword,core,,1.2.0-dev
error.message,text,core,,1.2.0-dev
error.stack_trace,keyword,core,,1.2.0-dev
event.action,keyword,core,user-password-change,1.2.0-dev
event.category,keyword,core,user-management,1.2.0-dev
event.code,keyword,extended,4648,1.2.0-dev
Expand Down
11 changes: 11 additions & 0 deletions generated/ecs/ecs_flat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,6 +1104,17 @@ error.message:
order: 1
short: Error message.
type: text
error.stack_trace:
description: The stack trace of this error in plain text.
doc_values: false
flat_name: error.stack_trace
ignore_above: 1024
index: false
level: core
name: stack_trace
order: 3
short: The stack trace of this error in plain text.
type: keyword
event.action:
description: 'The action captured by the event.

Expand Down
11 changes: 11 additions & 0 deletions generated/ecs/ecs_nested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,6 +1296,17 @@ error:
order: 1
short: Error message.
type: text
stack_trace:
description: The stack trace of this error in plain text.
doc_values: false
flat_name: error.stack_trace
ignore_above: 1024
index: false
level: core
name: stack_trace
order: 3
short: The stack trace of this error in plain text.
type: keyword
group: 2
name: error
prefix: error.
Expand Down
6 changes: 6 additions & 0 deletions generated/elasticsearch/6/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,12 @@
"message": {
"norms": false,
"type": "text"
},
"stack_trace": {
"doc_values": false,
"ignore_above": 1024,
"index": false,
"type": "keyword"
}
}
},
Expand Down
6 changes: 6 additions & 0 deletions generated/elasticsearch/7/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,12 @@
"message": {
"norms": false,
"type": "text"
},
"stack_trace": {
"doc_values": false,
"ignore_above": 1024,
"index": false,
"type": "keyword"
}
}
},
Expand Down
5 changes: 5 additions & 0 deletions generated/legacy/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,11 @@
"message": {
"norms": false,
"type": "text"
},
"stack_trace": {
"ignore_above": 1024,
"index": false,
"type": "keyword"
}
}
},
Expand Down
10 changes: 10 additions & 0 deletions schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,16 @@
"name": "error.message",
"required": false,
"type": "text"
},
"error.stack_trace": {
"description": "The stack trace of this error in plain text.",
"example": "",
"footnote": "",
"group": 2,
"level": "core",
"name": "error.stack_trace",
"required": false,
"type": "(not indexed)"
}
},
"group": 2,
Expand Down
8 changes: 8 additions & 0 deletions schemas/error.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,11 @@
type: keyword
description: >
Error code describing the error.

- name: stack_trace
level: core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this extended.

type: keyword
index: false
description: >
The stack trace of this error in plain text.