-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC Stage 1: TSDB Dimensions #2217
base: main
Are you sure you want to change the base?
Conversation
From Stage 0 to Stage 1, fields chosen as dimension fields were re-assessed here. Stage 1 thus has Three additions : in comparison with what is initially estimated in Stage 0. No similar changes are expected in near future. |
Related Stage 0 RFC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. @lalit-satapathy and team, please dive into the details of each field.
One general comment: There is currently a merger ongoing with semconv and in otel everything is a dimension which currently does not work with Elasticsearch. Before a lengthy discussion pops up around should this be in ECS or not, I would like to side step this and keep this PR moving.
There needs to be a more general discussion to have how we store additional info specific to Elasticsearch related to ECS in the future merged schema (or besides it). Lets do it in a separate issue.
Reasoning behind inclusions of fields as dimensions and changes from Stage 0 to Stage 1 are mentioned below
|
@agithomas , @lalit-satapathy Has a separate issue been created for this around the merged schema? Is there value in keeping this issue open anymore? |
This PR is stale because it has been open for 60 days with no activity. |
Have you signed the contributor license agreement? yes
Have you followed the contributor guidelines? yes
For proposing substantial changes or additions to the schema, have you reviewed the [RFC process] (https://github.com/elastic/ecs/blob/main/rfcs/README.md)? yes
If submitting code/script changes, have you verified all tests pass locally using make test?
If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
Have you added an entry to the CHANGELOG.next.md?