-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agent.ip #1027
Comments
Thanks for opening the issue @runesl. First, I'll mention that ECS always welcomes the use of custom fields to capture any fields needed for your use cases but not yet defined by ECS. By following that guidance, you run very little risk of having a future conflict. As you stated, Looking at We've recently consolidated a few other related discussions on this topic into a single issue, #940, and I've linked this issue there as well. If you have any thoughts or ideas to share in the meta issue discussion, feel welcome to add them. |
Thanks for the quick reply, ebeahan! The ip-address that a message is sent from, is not necesarily a static detail of the underlying system, which often has many ip's, but something that is assigned to the agent process when it does the OS bind call to claim a socket (ip+port) for sending the message. With serverless agents, things become even more dynamic, as "the host" can have a subnet of ip-adresses (think AWs lambda), and assign them to agent processes dynamicly. Thanks for the link to the very relevant issue on pipeline modeling. Having a generic model for the whole pipeline would be great. I hope it will eventually be able to capture the distinction between internal ip, as claimed by the agent itself, and remote ip as observed by the next receiver in the chain, which can differ due to spoofing or NAT'ing. |
Closing in favor of the pipeline details meta issue, #940. |
Summary
Add the agent.ip field to store ip address of the agent.
Motivation:
For many use case, such as audit logs, message authenticity is paramount. If you can't see where a message came from, and don't use complex security such as 2-way TLS, anyone with network access can pretend to be anyone else and send false messages (spoofing).
A simple way to determine the origin of a message, is to store the ip address of the agent it was received from. Many tools - including logstash' beats-input - can reliably store the ip address of the remote client that sent it a message. But ECS currently has no where to put this information.
Please don't confuse agent with host - they are not the same, and we need a place to store ip of both. Host is where the event was initially created. Later the event can pass through an agent (beat) on another machine with a different ip, before reaching logstash, on it's way to Elastic Search.
Also, this is not covered reliably by observer.ip_address. The observer is defined to be outside the host. This means, we cannot put the ip address of the agent in the observer field, for the events that are born inside the same host as the agent.
Since there is currently no consistent place to store the agent's ip in ECS, please add the agent.ip field.
The text was updated successfully, but these errors were encountered: