New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop setting `span.id`, set `transaction.id` for log correlation #146

Open

2 tasks

trentm opened this issue Jun 9, 2023 · 0 comments

Open

2 tasks

stop setting `span.id`, set `transaction.id` for log correlation #146

trentm opened this issue Jun 9, 2023 · 0 comments

Labels

Member

trentm commented Jun 9, 2023

I noticed in elastic/apm-agent-nodejs#3399 discussion that, while the ecs-logging-nodejs libs are currently setting span.id or transaction.id for log-correlation, the ecs-logging spec (https://github.com/elastic/ecs-logging/blob/main/spec/spec.json) only mentions setting transaction.id. So it appears these libs have this wrong.

TODO:

Confirm whether log-correlation works for log records that set trace.id and span.id. I.e. are these libs breaking log correlation for some log records?
Change to conform to the spec (and what the Java APM agent is doing).

The text was updated successfully, but these errors were encountered:

github-actions bot added the agent-nodejs label

trentm mentioned this issue

[doc] Align agents logs documentation elastic/apm-agent-nodejs#3399

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment