Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Drive connector is not retrieving last modified date #2977

Open
m-amano opened this issue Nov 19, 2024 · 2 comments
Open

Network Drive connector is not retrieving last modified date #2977

m-amano opened this issue Nov 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@m-amano
Copy link

m-amano commented Nov 19, 2024

Problem Description

The Network Drive connector's format_document method could potentially include the file's last modified date. Currently:

  1. _timestamp field uses change_time, which only updates when file permissions or metadata changes
  2. The actual last modified date of the file content (last_write_time) is not captured

Questions:

  • Is using change_time for _timestamp the intended behavior?
  • Would adding last_write_time as a new field be valuable for tracking actual file modifications?

Proposed Solution

Add last_write_time to capture when file content was last modified:

@m-amano m-amano added the enhancement New feature or request label Nov 19, 2024
@m-amano m-amano changed the title Network Drive connector should include file's last modified date Network Drive connector is not retrieving last modified date Nov 22, 2024
@m-amano
Copy link
Author

m-amano commented Nov 29, 2024

Could anyone please review this issue?

@artem-shelkovnikov
Copy link
Member

Hey @m-amano, what do you mean by reviewing the issue? It looks like your analysis is correct and doesn't seem hard to address :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants