Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SNS topics fetch panics on errors #2784

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jeniawhite
Copy link
Contributor

@jeniawhite jeniawhite commented Nov 28, 2024

Summary of your changes

Agentless agents were having panics on fetching SNS topics.

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

@jeniawhite jeniawhite requested a review from a team as a code owner November 28, 2024 08:46
Copy link

mergify bot commented Nov 28, 2024

This pull request does not have a backport label. Could you fix it @jeniawhite? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-v8.x has been added to help with the transition to the new branch 8.x.

@moukoublen
Copy link
Member

Should we backport to 8.17 as well?

@kubasobon @oren-zohar ?

@kubasobon
Copy link
Member

@moukoublen Yeah, I think nil-reference panic fixes merit a backport. I'm adding a label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Asset Inventory] Cloudbeat panics if SNS topic fetching returns error
3 participants