Add compile target to adopter registration stats #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we already show it on the "about" page, including it in this data seems like a good idea.
|
Opencast won't, but this does! Also, I kinda want to see a 3DS running Tobira now... |
|
Ah oh. Can we still merge this? How would that thing then handle different versions of Tobira that send different amount of data? |
|
Yep, since the stats aren't being collected right now anyway :D In the longer term, we add the additional fields to the registration server models. Fields with no data pushed end up full or blank string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we already show it on the "about" page, including it in this data seems like a good idea. Currently this could be
x86_64-unknown-linux-gnuorx86_64-unknown-linux-musl. Well, in theory it could be anything, who knows, maybe people manage to build Tobira formipsel-sony-psporarmv6k-nintendo-3ds.CC @gregorydlogan (though I'm fairly certain nothing else needs to change, as data is just piped through as is, if I remember correctly)