Clean up translations #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owi92
force-pushed
the
clean-up-translations
branch
from
213be85 to
575299b
Compare
LukasKalbertodt
requested changes
Sep 12, 2023
There was a problem hiding this comment.
Nice work! I haven't meticulously gone through the whole patch, as that's always a bit exhausting with refactor-commits. But I like your choices regarding translation file structure. I am a tiny bit uneasy not having checked every single place for missing translations, but I will just trust that our setup with the TypeScript check should catch those!
owi92
force-pushed
the
clean-up-translations
branch
from
575299b to
eed3f5d
Compare
github-actions
bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
owi92
force-pushed
the
clean-up-translations
branch
from
eed3f5d to
f742ef6
Compare
github-actions
bot
removed
the
status:conflicts
owi92
force-pushed
the
clean-up-translations
branch
from
f742ef6 to
eed3f5d
Compare
github-actions
bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
This moves any top-level strings to `general`, removes some (but not all) duplications, renames some strings and fixes some punctuation stuff.
owi92
force-pushed
the
clean-up-translations
branch
from
eed3f5d to
d1ee8fc
Compare
github-actions
bot
removed
the
status:conflicts
LukasKalbertodt
added
changelog:dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #841
This moves any top-level strings to
general, removes some (but not all) duplications, renames some strings and fixes some punctuation stuff, and removes one unsued translation. I suppose we could still move these around further/regroup some of them, but this should already be an improvement.I also used an external tool to check for any further unused translations, but it didn't report any. (Take that result with a grain of salt though, mainly because I'm not super sure I did the check correctly...)Edit: That tool didn't work... I checked some other tools but ultimately found it easier to go over the translations manually, and found a some more that were not being used.Another thing that is somewhat related to this is #857, which is still open but not forgotten. Maybe we can go over @oas777's suggestions soon and decide how to proceed with this.