Add return label to studio link #928
Conversation
github-actions
bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
owi92
force-pushed
the
send-label-to-studio
branch
from
a20ddcc to
f30032d
Compare
github-actions
bot
removed
the
status:conflicts
owi92
force-pushed
the
send-label-to-studio
branch
from
f30032d to
e3a0ba6
Compare
| params={{ "return.target": new URL(document.location.href) }} | ||
| params={{ | ||
| "return.target": new URL(document.location.href), | ||
| "return.label": "Tobira", |
There was a problem hiding this comment.
So mh, is "Tobira" the right string to pass there? Do you think the video portal name from the settings (which is shown as title of the root realm) is better? It could be quite long though, mhhh....
There was a problem hiding this comment.
Yeah, I think that might actually be better than just "Tobira". Might be long, sure, but hopefully institutions won't configure a name that is too long (I think that would also look a bit awkward on the homepage).
There was a problem hiding this comment.
Might be long, sure, but hopefully institutions won't configure a name that is too long (I think that would also look a bit awkward on the homepage).
https://tobira.unibe.ch/
"Video Portal University of Bern (Tobira)"
^ @dagraf :P
Ok seriously, I think Bern's title is still fine on the home page but might be a little bit crammed in the studio button. But oh well. Studio could also just limit the length of the button label. So yeah, let's do it like this.
owi92
force-pushed
the
send-label-to-studio
branch
from
e3a0ba6 to
79d940b
Compare
Closes #910
This adds a return label to the query parameters of Tobira's studio link. With this, studio users coming from Tobira will see where they are returning to after finishing their studio work.