Add user interface for ACL manipulation #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The administrator is always allowed to edit/manage stuff so their inclusion in the acl ui is at best redundant and at worst misleading for non-admin users. We still want to show the admin selection entry when the actual admin is logged in, so in cases where the acl doesn't explicitly includes it, it gets added manually.
Events can only be uploaded when the uploader is included in the acl with `write` access. The optional check here makes sure that it can't be removed when building the acl for an upload.
|
This pull request has conflicts ☹ |
github-actions
bot
added
the
status:conflicts
|
Closed since all changes made here are also included in #927 |
This was referenced Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #671
For now, this only handles dummy data, but in the future this will allow users to set ACL for every video they have write access for. This is done by adding or removing groups of people and/or single persons and setting read/write authorizations for these.