Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ACLs of events and series editable #356

Open
Tracked by #319
LukasKalbertodt opened this issue Mar 14, 2022 · 10 comments
Open
Tracked by #319

Make ACLs of events and series editable #356

LukasKalbertodt opened this issue Mar 14, 2022 · 10 comments
Labels
kind:new-feature A new feature needs:decision Needs a decision of some kind (discussion thread) status:blocked Blocked by something else

Comments

@LukasKalbertodt
Copy link
Member

LukasKalbertodt commented Mar 14, 2022

Users need the ability to change the visibility of series and events, i.e. to give different users or user groups access to events/series.

This is blocked by two big issues:

Once those are done, this issue itself probably won't be too hard to implement.

@LukasKalbertodt LukasKalbertodt added kind:new-feature A new feature needs:decision Needs a decision of some kind (discussion thread) labels Mar 14, 2022
@LukasKalbertodt LukasKalbertodt moved this to Todo in Tobira Mar 14, 2022
@dagraf
Copy link
Collaborator

dagraf commented Mar 21, 2022

Maybe you allready know this, but: Katrin is working for our own Opencast on integrating the ACL templates used by SWITCH into the core. You could maybe join forces.

@dagraf
Copy link
Collaborator

dagraf commented Aug 31, 2022

In my opinion this feature has as precondition feature #468
Meaning: I should be first able to see (in a nice way) what ACL i selected on a video and then I should be able to modify it.

JulianKniephoff added a commit that referenced this issue Dec 12, 2022
This makes it more extensible in the future. We certainly want to add
another sub page for ACLs/managing access (see #356). The previous
single page was already filled with lots of stuff and putting the
technical info on its own page helps with clarity.

See all commit messages for more detail.

<details>
<summary>Some notes and ideas on potential sub pages</summary>

- "Details"
  - Action buttons: Share, embed, open in Editor, ...
- Metadata (editiable): Title, Description, Creators, additional
metadata, start/end time?, Series
- "Access" (or "visibility")
  - UI to manage ACL of the video
- "Assets"
  - Section "Subtitles": show what subtitles exist and link to editor
  - Thumbnail: Show current thumbnail(s) and add link to editor
- "Technical information"
  - What is already contained in this PR

</details>
@LukasKalbertodt LukasKalbertodt added the status:blocked Blocked by something else label Jan 19, 2023
@LukasKalbertodt LukasKalbertodt moved this from Todo to Blocked 🛑 in Tobira Jan 19, 2023
@LukasKalbertodt LukasKalbertodt changed the title Add UI to modify ACLs of events and series Make ACLs of events and series editable Jan 19, 2023
@oas777
Copy link
Collaborator

oas777 commented Sep 21, 2024

We addressed and tabled this in our meeting, but could I have a short update here?

@JulianKniephoff
Copy link
Member

@oas777 are you talking about the "direct metadata update" stuff? Lars still has to schedule a meeting with at least Matthias and I. DACH probably delayed that.

@oas777
Copy link
Collaborator

oas777 commented Sep 25, 2024

No, I'm interested in the status of the overall feature of editing ACL for existing videos (which we currently only allow when uploading). If I understand Lukas initial comment correctly, this needs

@owi92
Copy link
Member

owi92 commented Sep 26, 2024

The UI from #671 can only be used once #631 is solved, which depends on the outcome of the meeting that Julian mentioned in his comment.

#468 doesn't necessarily depend on #631, so I could theoretically already start working on that.

@oas777
Copy link
Collaborator

oas777 commented Sep 26, 2024

I think #468 is less important than having #671 for existing videos and #631 therefore, but let's wait for @dagraf to speak.

@dagraf
Copy link
Collaborator

dagraf commented Oct 9, 2024

I agree, that #631 is the most important issue since it blocks #671. But as we will definitively need #468 (in my opinion) I would suggest @owi92 should start working on that. Let's discuss this in our todays meeting.

@LukasKalbertodt
Copy link
Member Author

From our meeting:

  • Show rough ACL information (in a nice way) on the public video page #468 we can already start (I added some details in that issue)
  • Regarding the blocker Opencast endpoints to change event/series metadata/ACL fast #631: we decided to try and ignore it. That means Tobira would send changes to Opencast (and potentially start a workflow) and just assume everything was saved.
    • This is in light of discussions around changing Opencast fundamentally, which would also resolve the blocker. That will likely only go in OC 18+ though.
    • Tobira would not lock an event for the time Opencast is running the workflow on it. That, unlike the other parts of this issue, would be quite a bit of work, touching way too many parts of Tobira. And since in the long term, we will use a proper solution, would be wasted time.
    • This feature would be hidden behind a config option, that explains potential risks with it.
    • We devs have to research how to make it work with the current Opencast APIs.

@oas777
Copy link
Collaborator

oas777 commented Oct 9, 2024

Re-visiting this for Lukas's summary: While "events and series" are in the title, we're talking "events" currently, right?

@owi92 owi92 moved this from Blocked 🛑 to Todo in Tobira Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:new-feature A new feature needs:decision Needs a decision of some kind (discussion thread) status:blocked Blocked by something else
Projects
Status: Todo
Development

No branches or pull requests

5 participants