Reconstruction: **[Particle Flow]** Validation of existing cluster-splitting and merging #897
Assignees
Labels
good first issue
Good for newcomers
help wanted
Extra attention is needed
TDR:Calorimetry
Relevant to calorimetry TDR wants/needs
topic: calorimetry
relates to calorimetry
topic: jets
topic: particle flow
topic: reconstruction
Comments
ruse-traveler
added
good first issue
ruse-traveler
added
topic: calorimetry
ruse-traveler
changed the title
|
Comment for posterity: I've added a flag indicating that this was identified a high-priority TDR need from the calorimetry side. |
ruse-traveler
changed the title
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 17, 2024
### Briefly, what does this PR introduce? This PR introduces the `TrackClusterMergeSplitter` algorithm, an algorithm for merging and splitting calorimeter clusters based on matched track projections. Inspired by the [Particle Flow algorithm from ATLAS](https://doi.org/10.1140/epjc/s10052-017-5031-2). ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [X] New feature (issue #897 ) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [X] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? Yes. Now "SplitMerge" `edm4eic::Cluster` collections and corresponding associations will be created for 6 of the central calorimeters (`NHCal`, `EEEMCal`, `BHCal`, `BIC`, `LFHCal`, and `FEMC`). Track projections will need to be extended to other calorimeters before the algorithm introduced here can be used on them. ### To-Do The split-merge parameters for each calorimeter need to be updated from the current dummy values used for testing. In the interest of getting the functionality of this algorithm merged, this could update could be done in a separate PR. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cluster splitting is currently enabled for a subset of calorimeters, and the algorithm may not be applicable to those which it isn't enabled. The latter point has not been explicitly confirmed yet.
Furthermore, cluster merging is very much an open question, particularly for the HCals. There is functionality for merging clusters in the existing Island Clustering Algorithm, but it may not be enabled nor appropriate for certain calorimeters.
The text was updated successfully, but these errors were encountered: