JetReconstruction: EDM improvements needed #724
Labels
improvement
Not a bug, not a feature, but an improvement of what is there
part:io
Input and output, PODIO and others
topic: jets
The current implementation of the JetReconstruction algo was done before JANA had native PODIO collections, so both jets and its constituents are stored in the same collection, with a hack:
EICrecon/src/algorithms/reco/JetReconstruction.cc
Line 66 in 158e3e0
EICrecon/src/algorithms/reco/JetReconstruction.cc
Line 80 in 158e3e0
EICrecon/src/algorithms/reco/JetReconstruction.cc
Line 67 in 158e3e0
EICrecon/src/algorithms/reco/JetReconstruction.cc
Line 81 in 158e3e0
We first need to acknowledge that jets are not representable as
edm4eic::ReconstructedParticle
(e.g. they have "area"). Though even if they are for now, they don't belong in the same collection with the constituents. We also don't need to store constituents, instead we should just refer to the originalChargedReconstructedParticles
/NeutralReconstructedParticles
/MCParticles
. That would not only allow to not duplicate the information unnecessarily, but also bring us closer to resolving a reported user issue: one currently can not relate jet constituents to the original track/cluster information.cc @ruse-traveler @bspage912 @ShujieL
The text was updated successfully, but these errors were encountered: