Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetReconstruction: EDM improvements needed #724

Open
veprbl opened this issue Jun 30, 2023 · 1 comment
Open

JetReconstruction: EDM improvements needed #724

veprbl opened this issue Jun 30, 2023 · 1 comment
Assignees
Labels
improvement Not a bug, not a feature, but an improvement of what is there part:io Input and output, PODIO and others topic: jets

Comments

@veprbl
Copy link
Member

veprbl commented Jun 30, 2023

The current implementation of the JetReconstruction algo was done before JANA had native PODIO collections, so both jets and its constituents are stored in the same collection, with a hack:

We first need to acknowledge that jets are not representable as edm4eic::ReconstructedParticle (e.g. they have "area"). Though even if they are for now, they don't belong in the same collection with the constituents. We also don't need to store constituents, instead we should just refer to the original ChargedReconstructedParticles/NeutralReconstructedParticles/MCParticles. That would not only allow to not duplicate the information unnecessarily, but also bring us closer to resolving a reported user issue: one currently can not relate jet constituents to the original track/cluster information.

cc @ruse-traveler @bspage912 @ShujieL

@veprbl
Copy link
Member Author

veprbl commented Jun 30, 2023

See also #725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Not a bug, not a feature, but an improvement of what is there part:io Input and output, PODIO and others topic: jets
Projects
Status: In Progress
Development

No branches or pull requests

3 participants