Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRAM second port has "no connect" inputs #51

Open
RTimothyEdwards opened this issue Oct 4, 2022 · 2 comments
Open

SRAM second port has "no connect" inputs #51

RTimothyEdwards opened this issue Oct 4, 2022 · 2 comments
Assignees
Labels
error Something isn't working RTL Changes to verilog source wontfix This will not be worked on

Comments

@RTimothyEdwards
Copy link
Contributor

caravel_mgmt_soc_litex verilog module verilog/rtl/mgmt_core_wrapper.v has the pins sram_ro_clk, sram_ro_csb, and sram_ro_addr are no-connects. These must be connected, to ground if nothing else. Also see the issue in the caravel repository issue number 6---this value could be controlled by housekeeping through the SPI, which is the preferable implementation if it has to be fixed anyway.

@RTimothyEdwards RTimothyEdwards added error Something isn't working RTL Changes to verilog source labels Oct 4, 2022
@jeffdi jeffdi moved this from Todo to In Progress in Caravel Redesign Oct 5, 2022
@jeffdi
Copy link
Collaborator

jeffdi commented Oct 6, 2022

RTL implemented. Just needs a testbench.

@jeffdi jeffdi moved this from In Progress to Implementation Complete in Caravel Redesign Oct 6, 2022
@jeffdi jeffdi removed this from Caravel Redesign Oct 6, 2022
@RTimothyEdwards
Copy link
Contributor Author

RTimothyEdwards commented Oct 7, 2022

This one will not be fixed since we have made the decision to remove the SRAM and replace it with DFFRAM (which doesn't have a 2nd read-only port). The read-only ports have been removed from the LiteX core and `ifdef'd out of the housekeeping and top levels. See issue #57, which supercedes this issue.

@RTimothyEdwards RTimothyEdwards added the wontfix This will not be worked on label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error Something isn't working RTL Changes to verilog source wontfix This will not be worked on
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants