Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONIC-696: Disable Wallets via code in the Legacy Payment Flow #14

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

NawfalAhmed
Copy link
Member

@NawfalAhmed NawfalAhmed commented Sep 5, 2024

Anyone merging to this repository is expected to promptly release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.

Description

  • Disable wallets in stripe form

We are planning to enable wallet payment options i.e Google Pay and Apple Pay, in our new CT checkout flow. However, since our Stripe account is shared across platforms, these options would also appear on payment.edx.org. Ideally, wallet options should only be displayed for trusted domains. Unfortunately, Stripe does not seem to enforce this setting correctly, as the wallet options are showing up on unregistered domains like payment.edx.org/payment.stage.edx.org. Given that our current Stripe payment logic does not support wallets and Stripe is not respecting domain restrictions, We are disabling wallets as a payment method in the Stripe payment options via code

Currently on stage when google pay is enabled:
image

Supporting information

Jira Ticket: https://2u-internal.atlassian.net/browse/SONIC-696

Checklist

  • Consider PCI compliance impact and whether this PR changes how credit card information is handled.
  • Intend to release and monitor this PR promptly after merge.

@NawfalAhmed NawfalAhmed requested a review from a team as a code owner September 5, 2024 17:04
@NawfalAhmed NawfalAhmed self-assigned this Sep 5, 2024
@NawfalAhmed NawfalAhmed merged commit 7446be2 into master Sep 6, 2024
5 checks passed
@NawfalAhmed NawfalAhmed deleted the nahmed/sonic-696/disable-wallets branch September 6, 2024 12:47
@NawfalAhmed
Copy link
Member Author

Wallets successfully disabled on staging for all users
for a affirm valid users the affirm option would still display
Screenshot 2024-09-06 at 6 39 40 PM
and for normal users only cards
Screenshot 2024-09-06 at 6 41 51 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants