Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DATADOG_DIAGNOSTICS_ENABLE feature switch in edx-arch-experiments #771

Closed
2 tasks done
timmc-edx opened this issue Aug 12, 2024 · 2 comments
Closed
2 tasks done
Assignees

Comments

@timmc-edx
Copy link
Member

timmc-edx commented Aug 12, 2024

Version 4.1.0 introduced logging of all span-starts for the first 60 seconds of each worker's lifetime. but I configured prod LMS to not use this functionality. Except the feature switch doesn't actually work, so we've had to downgrade to 4.0.0.

A/C:

  • Release a safe version of edx-arch-experiments (either with a fixed toggle, or one that at least defaults to false)
  • Figure out how this happened and how to prevent it in the future
@timmc-edx timmc-edx converted this from a draft issue Aug 12, 2024
timmc-edx added a commit that referenced this issue Aug 12, 2024
I still don't understand why this setting loading was broken -- maybe
there's something unusual about the way plugin apps are loaded?

This addresses #771
timmc-edx added a commit that referenced this issue Aug 13, 2024
…772)

I still don't understand why this setting loading was broken -- maybe
there's something unusual about the way plugin apps are loaded?

This addresses #771
@timmc-edx
Copy link
Member Author

I've figured out why we had this problem in this app -- our plugin app implementation loads each app while the IDA's Django settings module is being imported, which means the Django settings haven't loaded yet. (Even the settings from higher in the file aren't available.) For now I'll add a warning in the plugin apps docs but maybe we want to load plugins differently (e.g. delayed until after settings have loaded.)

@github-project-automation github-project-automation bot moved this from In Progress to Done in Arch-BOM Aug 14, 2024
@jristau1984 jristau1984 moved this from Done to Done - Long Term Storage in Arch-BOM Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done - Long Term Storage
Development

No branches or pull requests

1 participant