-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix commitlint issue affecting automated comment on codeowner PRs #693
Comments
Feanil said that using v5 should bring the latest, so I'm not sure why this is still broken, unless the fix is not fully fixed. |
[inform] I manually deleted a section of the commit message that allowed it to pass commitlint. See https://github.com/edx/edx-internal/pull/11132#issuecomment-2186765583 for what I deleted, and the PR description for the original message. We might be able to use this to find the simplest case we can get to fail, and then open an issue on commitlint for it. |
Had to manually fix again on Jul 16 for edx/edge-internal PRs. |
An attempt to fix this more permanently was made here: https://github.com/edx/jenkins-job-dsl-internal/pull/873. We don't yet know if it worked. |
This has been completed. |
Codeowner PRs like the following are failing on commitlint.
I thought the following Axim ticket might fix, but I didn't understand github action versioning:
We have a temporary workaround, as detailed in #693 (comment). We also may need to open an issue on commitlint, unless we find some other fix, and provide an example failing commit message that should pass.
The text was updated successfully, but these errors were encountered: