Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commitlint issue affecting automated comment on codeowner PRs #693

Closed
robrap opened this issue Jun 21, 2024 · 5 comments
Closed

Fix commitlint issue affecting automated comment on codeowner PRs #693

robrap opened this issue Jun 21, 2024 · 5 comments
Assignees
Labels

Comments

@robrap
Copy link
Contributor

robrap commented Jun 21, 2024

Codeowner PRs like the following are failing on commitlint.

I thought the following Axim ticket might fix, but I didn't understand github action versioning:

We have a temporary workaround, as detailed in #693 (comment). We also may need to open an issue on commitlint, unless we find some other fix, and provide an example failing commit message that should pass.

@robrap robrap added this to Arch-BOM Jun 21, 2024
@robrap robrap converted this from a draft issue Jun 21, 2024
@robrap robrap moved this from On-Call to Blocked in Arch-BOM Jun 21, 2024
@robrap
Copy link
Contributor Author

robrap commented Jun 22, 2024

Feanil said that using v5 should bring the latest, so I'm not sure why this is still broken, unless the fix is not fully fixed.

@robrap
Copy link
Contributor Author

robrap commented Jun 24, 2024

[inform] I manually deleted a section of the commit message that allowed it to pass commitlint. See https://github.com/edx/edx-internal/pull/11132#issuecomment-2186765583 for what I deleted, and the PR description for the original message. We might be able to use this to find the simplest case we can get to fail, and then open an issue on commitlint for it.

@robrap robrap changed the title Fix commitlint and land codeowner PRs Fix commitlint issue affecting automated comment on codeowner PRs Jun 24, 2024
@robrap robrap moved this from Blocked to Prioritized in Arch-BOM Jun 24, 2024
@robrap robrap removed the status in Arch-BOM Jun 24, 2024
@robrap
Copy link
Contributor Author

robrap commented Jul 16, 2024

Had to manually fix again on Jul 16 for edx/edge-internal PRs.

@jristau1984 jristau1984 moved this to Backlog in Arch-BOM Jul 22, 2024
@robrap
Copy link
Contributor Author

robrap commented Aug 12, 2024

An attempt to fix this more permanently was made here: https://github.com/edx/jenkins-job-dsl-internal/pull/873. We don't yet know if it worked.

@robrap robrap moved this from Backlog to In Progress in Arch-BOM Oct 2, 2024
@robrap robrap self-assigned this Oct 2, 2024
@robrap
Copy link
Contributor Author

robrap commented Oct 2, 2024

This has been completed.

@robrap robrap closed this as completed Oct 2, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Arch-BOM Oct 2, 2024
@jristau1984 jristau1984 moved this from Done to Done - Long Term Storage in Arch-BOM Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done - Long Term Storage
Development

No branches or pull requests

2 participants