Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start installing codejail requirements from base.txt instead of py38.txt #630

Open
timmc-edx opened this issue May 8, 2024 · 16 comments
Open
Assignees

Comments

@timmc-edx
Copy link
Member

timmc-edx commented May 8, 2024

The structure of the edxapp-sandbox-requirements has changed and we need to switch in order to keep getting updates: openedx/edx-platform#34509

First step: Determine priority, may be able to lower it.

@kdmccormick
Copy link

kdmccormick commented May 8, 2024

Nice, you caught this before I got around to bugging you about it :) Just a heads up, as I tried to explain here, we plan to keep requirements/edx/base.txt and requirements/edx-sandbox/base.txt synced in terms of constraints and language version. So, once Py3.8 support is dropped from edx-platform, it will be simultaneously be dropped for edx-sandbox. That might be exactly what you folks want, or it might not be, I'm not sure--just want to make sure you folks have all the information you need as you decide between quince.txt redwood.txt and base.txt.

@timmc-edx timmc-edx moved this to Prioritized in Arch-BOM May 9, 2024
@jristau1984
Copy link

Putting down a due date of "something like the Sumac release", so that we dont lose this. The thought is that this can be added to a "pipeline" related epic in H2 2024.

@jristau1984 jristau1984 moved this from Prioritized to Backlog in Arch-BOM Jul 30, 2024
@robrap
Copy link
Contributor

robrap commented Aug 5, 2024

Noting that it is entirely up to 2U when we want to get off an unsupported version of Python. It would be good for us to clean-up the unused file once we are done with it, but Axim does not plan on deleting this file. In other words, we don't have an external deadline for this work.

@robrap
Copy link
Contributor

robrap commented Aug 15, 2024

Additional questions:

  1. Would it makes sense to move to Python 3.12 (rather than 3.11) to minimize the number of upgrades?
  2. Would it make sense to bump Ubuntu versions to minimize upgrades? See Test edx-platform on Ubuntu 22.04 openedx/edx-platform#35314

@robrap
Copy link
Contributor

robrap commented Aug 16, 2024

Note: Ubuntu 20.04 standard support runs out April 2025, and this upgrade work may need to be ticketed separately with SRE. I simply wanted to note that we need to take some action somewhere.

@robrap
Copy link
Contributor

robrap commented Dec 16, 2024

[inform] We missed the due date. Do we want to schedule this work?

@robrap
Copy link
Contributor

robrap commented Dec 16, 2024

FYI: @jristau1984

@jristau1984
Copy link

jristau1984 commented Dec 17, 2024

@robrap I believe that Arbi-BOM started the upgrade the sandbox environment to Python 3.11 as a pre-requisite for several other testing efforts where sandboxes were needed. This is the issue related to that effort: #850.

It looks like there is a need to complete that work, which I will follow up with ARbi-Bom about in our next touchpoint.

@robrap robrap removed the status in Arch-BOM Dec 17, 2024
@robrap
Copy link
Contributor

robrap commented Dec 17, 2024

@timmc-edx: Can you confirm if this is complete? Thank you.

@timmc-edx
Copy link
Member Author

timmc-edx commented Dec 17, 2024

No, our codejail is still running in Python 3.8.10. (This is distinct from 2U's sandboxes; "sandbox" in the meaning of this ticket actually refers to codejail.)

EDIT: Here's a quick way to check the codejail environment if you can add a problem to a course:

<problem>
  <customresponse>
    <script type="loncapa/python">

import sys
out = f"Python version: {sys.version}"

    </script>
    <p>Output:</p>
    <pre>$out</pre>
  </customresponse>
</problem>

@robrap
Copy link
Contributor

robrap commented Dec 18, 2024

We're considering whether it would be better to do this before or after containerization.

@kdmccormick
Copy link

Separate from 2U's edx-sandbox 3.8->3.11 upgrade, the cleanup that we're hoping to do from the openedx side is just to delete py38.txt, which is just a simple pointer to quince.txt. To avoid being broken by that cleanup, I recommend just updating your edx-sandbox deployment to point at quince.txt instead of py38.txt. You could then schedule the 3.8->3.11 edx-sandbox upgrade at your own pace with no openedx-based pressure.

@robrap
Copy link
Contributor

robrap commented Dec 18, 2024

@kdmccormick: Do you know why quince.txt is crossed out in your earlier comment? See #630 (comment)

@kdmccormick
Copy link

I do not-- I must have been confused. quince.txt is indeed what you want if you have been using py38.txt up until this point.

@robrap
Copy link
Contributor

robrap commented Dec 18, 2024

PR for pointing to more permanent requirements file:

@robrap
Copy link
Contributor

robrap commented Dec 18, 2024

  • When we land the PR I posted, we should be able to do the minor clean-up of removing the py38.txt file.
  • Separately, Python 3.8 has gone out of support, so we'll still want to complete the upgrade.

@robrap robrap moved this to In Progress in Arch-BOM Dec 18, 2024
@robrap robrap self-assigned this Dec 18, 2024
@robrap robrap moved this from In Progress to In Review in Arch-BOM Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

No branches or pull requests

4 participants